Finished #805
Open
Finished #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanilWeda
suggested changes
Dec 3, 2024
src/errorHandler.js
Outdated
Comment on lines
4
to
10
| const isToCaseUnaccepted = | ||
| toCase !== 'SNAKE' && | ||
| toCase !== 'KEBAB' && | ||
| toCase !== 'CAMEL' && | ||
| toCase !== 'PASCAL' && | ||
| toCase !== 'UPPER' && | ||
| !isToCaseParamApsent; |
There was a problem hiding this comment.
You can make array with all values, than use includes or something like that.
src/errorHandler.js
Outdated
Comment on lines
16
to
18
| message: | ||
| 'Text to convert is required. Correct request' + | ||
| ' is: "/<TEXT_TO_CONVERT>?toCase=<CASE_NAME>".', |
src/errorHandler.js
Outdated
| ); | ||
|
|
||
| return true; | ||
| } else { |
src/req.js
Outdated
Comment on lines
23
to
36
| // const response = ''; | ||
|
|
||
| res.on('data', (chunk) => { | ||
| // response += chunk.toString() + '\n'; | ||
| }); | ||
|
|
||
| res.on('end', () => { | ||
| // console.log('Response from server:', response); | ||
| }); | ||
| }); | ||
|
|
||
| // req.on('error', (error) => { | ||
| // console.log(error); | ||
| // }); |
There was a problem hiding this comment.
Remove commented ( I see comment above)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd appreciate some advices to code style and structure)